Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port remove fix #14438

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Sep 26, 2023

Purpose

A small fix to only show warning message when removing ports on Python nodes.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • now only shows warning prompt if the node is a Python node

Reviewers

@QilongTang

FYIs

@reddyashish

- now only shows warning prompt if the node is a Python node
@QilongTang QilongTang added this to the 3.0 milestone Sep 26, 2023
@QilongTang QilongTang merged commit 1844d86 into DynamoDS:master Sep 26, 2023
@QilongTang QilongTang mentioned this pull request Oct 11, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants