Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6259 Fix Handling preferences bearing in mind the hosts (#14427) #14431

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

QilongTang
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Cherry-picking #14427

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

FYIs

@DynamoDS/dynamo

* Fix Handling preferences bearing in mind the hosts

* Creating the Preferences on demand

---------

Co-authored-by: Jesus Alfredo Alviño <[email protected]>
@QilongTang QilongTang added this to the 2.19.2 milestone Sep 22, 2023
@github-actions
Copy link

⚠️ [run-bin-diff] - Files Added/Deleted::73 new file(s) have been added and 154 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::15 new file(s) have been added and 32 file(s) have been deleted!

@QilongTang QilongTang merged commit 62477a1 into RC2.19.2_master Sep 22, 2023
@QilongTang QilongTang deleted the CherryPick branch September 22, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants