-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphic helpers - 2.19 hotfix #14425
graphic helpers - 2.19 hotfix #14425
Conversation
- graphic scale units not taking effect in Dynamo - added check to disable host settings interfering with Dynamo settings - renamed resource for Show Grid to Show Helpers
|
hi @dnenov Would you split the menu item rename changes to master branch only? |
- revert menu item name change, will move it to Master instead
Reverted the menu item changes, they were the culprit for the failing regressions as well. I will do a separate PR for those against master and investigate why the tests were failing. |
- setting scale units would override the visibility of the grid - now checks the grid, and if disabled, toggles it back to the correct setting
@QilongTang @reddyashish parallel tests passed, are we good to merge this? |
Purpose
This is a hot-fix for an issue preventing Graphic Elements Scale to take effect in Dynamo. The
UseHostScaleUnits
preference that controls if Revit scale units should be used was acting even if Dynamo was used without a host.Show Grid renamed to Show HelpersGraphic Scale Units under Dynamo and Revit
Serializing settings
Separate settings
.xaml
files for Dynamo and RevitDeclarations
Check these if you believe they are true
*.resx
filesRelease Notes
- renamed resource for Show Grid to Show HelpersReviewers
@QilongTang
@reddyashish
FYIs
@Amoursol