Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphic helpers - 2.19 hotfix #14425

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Sep 20, 2023

Purpose

This is a hot-fix for an issue preventing Graphic Elements Scale to take effect in Dynamo. The UseHostScaleUnits preference that controls if Revit scale units should be used was acting even if Dynamo was used without a host.
Show Grid renamed to Show Helpers

Graphic Scale Units under Dynamo and Revit

dyanmo units

revit metric

Serializing settings

image

Separate settings .xaml files for Dynamo and Revit

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • graphic scale units not taking effect in Dynamo - added check to disable host settings interfering with Dynamo settings
    - renamed resource for Show Grid to Show Helpers

Reviewers

@QilongTang
@reddyashish

FYIs

@Amoursol

- graphic scale units not taking effect in Dynamo - added check to disable host settings interfering with Dynamo settings
- renamed resource for Show Grid to Show Helpers
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

⚠️ [run-bin-diff] - Files Added/Deleted::73 new file(s) have been added and 154 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::15 new file(s) have been added and 32 file(s) have been deleted!
(Updated: 2023-09-22-15:55:46)

@QilongTang
Copy link
Contributor

hi @dnenov Would you split the menu item rename changes to master branch only?

@QilongTang QilongTang changed the base branch from RC2.19.0_master to RC2.19.2_master September 21, 2023 15:52
- revert menu item name change, will move it to Master instead
@dnenov
Copy link
Collaborator Author

dnenov commented Sep 21, 2023

Also Regressions: DynamoCoreWpfTests.CoreUserInterfaceTests.WorkspaceContextMenu_TestIfOpenOnRightClick WpfVisualizationTests.HelixWatch3DViewModelTests.HelixWatch3DViewModel_OpenFileWithGridDisabled_EnableGrid_GridDraws WpfVisualizationTests.HelixWatch3DViewModelTests.HelixWatch3DViewModel_OpenFileWithGridDisabled_GridDoesNotDraw

Reverted the menu item changes, they were the culprit for the failing regressions as well. I will do a separate PR for those against master and investigate why the tests were failing.

@QilongTang QilongTang added this to the 2.19.2 milestone Sep 21, 2023
- setting scale units would override the visibility of the grid
- now checks the grid, and if disabled, toggles it back to the correct setting
@mjkkirschner
Copy link
Member

@QilongTang @reddyashish parallel tests passed, are we good to merge this?
@dnenov will you cherry pick to master?

@QilongTang QilongTang merged commit 854f50d into DynamoDS:RC2.19.2_master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants