Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing legacy search in Dynamo #14413

Merged
merged 7 commits into from
Sep 16, 2023
Merged

Conversation

reddyashish
Copy link
Contributor

Purpose

This is to remove the legacy search in Dynamo and Lucene search will be used in all components.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Removing legacy search in Dynamo

Reviewers

@QilongTang @RobertGlobant20

FYIs

@DynamoDS/dynamo

@QilongTang QilongTang added this to the 3.0 milestone Sep 14, 2023
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments. Also, this fork doesn't seem to build.

@reddyashish
Copy link
Contributor Author

Building fine now, needed to change one of the recently added lucene test.

@QilongTang
Copy link
Contributor

Building fine now, needed to change one of the recently added lucene test.

Cool, waiting for PR checks

@QilongTang
Copy link
Contributor

@reddyashish
Copy link
Contributor Author

Fixed the test now.

@reddyashish reddyashish merged commit 9846e7c into DynamoDS:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants