Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove space below filters #14406

Merged
merged 3 commits into from
Sep 15, 2023
Merged

remove space below filters #14406

merged 3 commits into from
Sep 15, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Sep 13, 2023

Purpose

A small PR removing the leftover space between the filters bar and the data grid underneath. The 'clear all' button will shift the tow of filter tags when visible.

UI Changes

remove space between filters and datagrid

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • removed the spacing between the filters bar and the datagrid

Reviewers

@Amoursol
@QilongTang

FYIs

@reddyashish

- removed the spacing between the filters bar and the datagrid
@QilongTang QilongTang added this to the 3.0 milestone Sep 13, 2023
@reddyashish reddyashish merged commit a061335 into DynamoDS:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants