-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm search for packages - votes #14390
Merged
reddyashish
merged 15 commits into
DynamoDS:master
from
dnenov:pm-searchforpackages-votes
Oct 27, 2023
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4913db8
votes cherry pick
dnenov 9cc4769
Greg update
dnenov fc2437a
Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…
dnenov 42c3ee4
Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…
dnenov 5700541
Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…
dnenov 274f4a8
votes cherry pick
dnenov 0b13c6e
minor fixes
dnenov 61acda0
Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…
dnenov 0d34642
Greg - Duplicate 'PackageReference' items found
dnenov 4b0382d
Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…
dnenov 25d73b5
references reconciliation
dnenov dffb0cf
reference fix
dnenov e70eaaf
revert assemblyinfo changes
dnenov 656a1df
failing tests fix
dnenov 2f0e46c
Merge remote-tracking branch 'upstream/master' into pm-searchforpacka…
dnenov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Threading.Tasks; | ||
using Dynamo.Graph.Workspaces; | ||
using Greg; | ||
using Greg.Requests; | ||
using Greg.Responses; | ||
using System.Linq; | ||
|
||
namespace Dynamo.PackageManager | ||
{ | ||
|
@@ -65,6 +65,18 @@ internal bool Upvote(string packageId) | |
}, false); | ||
} | ||
|
||
internal List<string> UserVotes() | ||
{ | ||
var votes = FailFunc.TryExecute(() => | ||
{ | ||
var nv = new GetUserVotes(); | ||
var pkgResponse = this.client.ExecuteAndDeserializeWithContent<UserVotes>(nv); | ||
return pkgResponse.content; | ||
}, null); | ||
|
||
return votes.has_upvoted; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the local variable votes will be null when the function fails. Check for null before returning its property. |
||
} | ||
|
||
internal PackageManagerResult DownloadPackage(string packageId, string version, out string pathToPackage) | ||
{ | ||
try | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be added, that is why the self-serve is failing.