partially revert #13744 and add comments #14377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,6 +260,7 @@ private static string GetStringFromObject(object obj) | |||
| return ObjectToLabelString(obj); | |||
| case TypeCode.Double: | |||
| return ((double)obj).ToString(numberFormat, CultureInfo.InvariantCulture); | |||
| //!!!!carefully consider the consequences of this change before uncommenting. | |||
aparajit-pratap
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As a first step toward addressing the bug report here:
#14369
This PR just reverts the initial string preview transformations, we can merge there and then quickly cherry pick to 2.19. Even though I intend to send a proposal for an alternative string format improvement to master, I want to make sure these changes make it to master and 2.19.
strings now stay strings.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix bug with numeric display in preview bubbles.
Reviewers