-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm publish a package - numeric up/down control #14374
Conversation
- Updated numeric input: free input or use carets to increase/decrease number
@@ -2190,7 +2199,7 @@ Uninstall the following packages: {0}?</value> | |||
<value>Version {0} of {1} could not be found.</value> | |||
</data> | |||
<data name="PublishPackageViewPackageHostDependency" xml:space="preserve"> | |||
<value>External Dependency (optional)</value> | |||
<value>Host (optional)</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to revisit this with @hwahlstrom again. I feel this change would eliminate the chance of describing a Dynamo package depending on external software existence rather than integration or host. I think the term Host
is very limited to the current way Dynamo is integrated, so we did not pick this term in the first place.
But I guess @hwahlstrom 's starting point is that external dependency may not be trivial enough for users to understand in the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we can find the bandwidth to rethink this system - there was a pretty good discussion originally and we discarded some flexible ideas because of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QilongTang Do you mean the change of terminology from External Dependency to Host? The drop-down only has hosts. If we want a way to introduce dependencies other than hosts, I'm happy to think that through. However, if we are only offering hosts, let's use the simpler term that more users will understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then LGTM
src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPublishControl.xaml
Outdated
Show resolved
Hide resolved
- replaced the xctk:IntegerUpDown with native wpf custom user control to reduce reliance on external dependencies
src/DynamoCoreWpf/Views/PackageManager/Controls/NumericUpDownControl.xaml.cs
Show resolved
Hide resolved
src/DynamoCoreWpf/Views/PackageManager/Controls/NumericUpDownControl.xaml.cs
Show resolved
Hide resolved
- now only allows positive whole numbers
Purpose
This is a short PR with some of the UI changes to the 'Publish' tab in the package manager. The work in this PR focuses around the updated numeric input control for package versions.
UI Changes
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
IntegerUpDown
control from DotNetProjects.Extended.Wpf.Toolkit, which is already part of DynamoCoreWpfReviewers
@QilongTang
@reddyashish
FYIs
@Amoursol