Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGD-3085 : fix cast crash #14351

Merged
merged 1 commit into from
Aug 31, 2023
Merged

AGD-3085 : fix cast crash #14351

merged 1 commit into from
Aug 31, 2023

Conversation

BogdanZavu
Copy link
Contributor

Purpose

Fix a crash when the renderPackage is not a HelixRenderPackage

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

@QilongTang
Copy link
Contributor

Nice catch, can the crash case be written into a unit test?

@BogdanZavu
Copy link
Contributor Author

@saintentropy @twastvedt FYI

@BogdanZavu
Copy link
Contributor Author

@QilongTang I think this is more of an integration test ; this utility is not covered and it's usage is related to a more complex workflow which involves rendering - but it will be tested as part of player integration tests which are in the works.

@BogdanZavu BogdanZavu merged commit e4ef88c into DynamoDS:master Aug 31, 2023
@QilongTang
Copy link
Contributor

@QilongTang I think this is more of an integration test ; this utility is not covered and it's usage is related to a more complex workflow which involves rendering - but it will be tested as part of player integration tests which are in the works.

Thank you! Make sense

BogdanZavu added a commit to BogdanZavu/Dynamo that referenced this pull request Sep 6, 2023
BogdanZavu added a commit to BogdanZavu/Dynamo that referenced this pull request Sep 6, 2023
QilongTang pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants