Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm publish a package - remove item fix #14334

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Aug 27, 2023

Purpose

PM publish a package - remove item functionality fix.

fixed delete file

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixed remove item functionality by updating datacontext to the correct one containing the command

Reviewers

@QilongTang

FYIs

@reddyashish

- fixed remove item functionality by updating datacontext to the correct one containing the command
@QilongTang QilongTang added this to the 3.0 milestone Aug 28, 2023
@QilongTang
Copy link
Contributor

Reported regression seems to be an issue on master branch not this fork. Merging

@QilongTang QilongTang merged commit 2a1498e into DynamoDS:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants