bugfix[DYN-6170]clicking-on-library-category-does-not-navigate-to-respective-category #14313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
approved these changes
Aug 24, 2023
QilongTang
reviewed
Aug 24, 2023
| @@ -362,7 +362,7 @@ private void Browser_KeyDown(object sender, KeyEventArgs e) | |||
| { | |||
| if (e.Key == Key.Delete) | |||
| { | |||
| _ = ExecuteScriptFunctionAsync(browser, "dispatchEvent"); | |||
| _ = ExecuteScriptFunctionAsync(browser, "eventDispatcher"); | |||
There was a problem hiding this comment.
@Enzo707 Why the previous name of the function does not work?
There was a problem hiding this comment.
@QilongTang It had the same name as javascript dispatchEvent method so it was re-trigged the event twice
QilongTang
approved these changes
Aug 24, 2023
|
@Enzo707 Given this is a regression in v2.19, please also cherry-pick to |
Enzo707
added a commit
to Enzo707/Dynamo
that referenced
this pull request
Aug 24, 2023
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fix the navigation to a clicked category within library search results list.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
This PR renames the function that dispatch forward delete event
dispatchEventtoeventDispatcheravoiding side effects that prevent navigation to the clicked library category.Reviewers
@QilongTang
FYIs
@avidit