Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph node manager updates #14307

Merged

Conversation

dariaivanciucova
Copy link
Contributor

@dariaivanciucova dariaivanciucova commented Aug 23, 2023

Purpose

This PR contains the following changes to the GraphNodeManager extension UI:
Figma link

  • Replaced Function icon with updated version
    image

  • Copy to Clipboard includes the original node name as well as the renamed node name

    Graph Node Manager  - Copy warning

  • Added List Counter for top level items and single item icon
    image
    TODO: replace text with icons

  • Moved Export button to bottom of the nodes table, replaced the icon with text button.
    Graph Node Manager  - Export updated

  • updated font size to match Figma

  • added header vertical separators to match Figma

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Quality of Life improvements to Graph Node Manager.

Reviewers

@reddyashish
@QilongTang

FYIs

@dnenov
@Amoursol

- bigger text
- header dividers
- add labels for single and multiple outputs
- added original name when copying node info
- added separator to table headers
@QilongTang QilongTang added this to the 3.0 milestone Aug 24, 2023
@QilongTang
Copy link
Contributor

Cannot find the static member 'Title_TopLevelItemsNumber' on the type 'Resources'. [D:\a\Dynamo\Dynamo\net60_Win_Dynamo\src\GraphNodeManagerViewExtension\GraphNodeManagerViewExtension.csproj] This fork does not build

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments but this fork does not build, waiting for more changes. Also, can you make a gif how to trigger the copy node info button? I cant see it locally

- reordered usings with 'System' on top
- added comments to new properties in GridNodeViewModel
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::3 new file(s) have been added

@QilongTang
Copy link
Contributor

QilongTang commented Sep 8, 2023

⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::3 new file(s) have been added

@dariaivanciucova @dnenov What are the three new files added by this PR? Taking that back, I saw similar comment reported by our bin diff job so this looks like a false alarm

@QilongTang QilongTang merged commit 8bf33b2 into DynamoDS:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants