Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6124: add library js after code smells improvements #14300

Merged

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Aug 22, 2023

Purpose

This PR includes librarie.min.js file after improvements related to library code smells reports
Ref.: DynamoDS/librarie.js#189

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Removes useless functions and commented legacy code
  • Updates according to ES6+ and javaScript recommended standards

Reviewers

@QilongTang

FYIs

@RobertGlobant20

@QilongTang QilongTang added this to the 3.0 milestone Aug 22, 2023
@QilongTang QilongTang merged commit 85b7921 into DynamoDS:master Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants