Fix Node Autocomplete Regressions #14275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due that we are adding ZeroTouchNodes during test mode around 9 tests are failing, seems that there are several nodes duplicates so each test needs to be analyzed separately. Then in this fix I'm reverting the code for adding ZeroTouchNodes and also removing a test that will fail due to this change.
|
All the tests are passing locally |
reddyashish
reviewed
Aug 17, 2023
| /// </summary> | ||
| [Test] | ||
| [Category("UnitTests")] | ||
| public void WhenStartingDynamoOperatorNodesNolongerMissingFromSearch() |
There was a problem hiding this comment.
Mark it as failure instead of removing it, when merging the PR
There was a problem hiding this comment.
[Category("UnitTests")] should also be present.
Re-adding unit test with Failure category
QilongTang
approved these changes
Aug 17, 2023
QilongTang
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Fix Node Autocomplete Regressions Due that we are adding ZeroTouchNodes during test mode around 9 tests are failing, seems that there are several nodes duplicates so each test needs to be analyzed separately. Then in this fix I'm reverting the code for adding ZeroTouchNodes and also removing a test that will fail due to this change. * Fix Node Autocomplete Regressions Re-adding unit test with Failure category
9 tasks
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Fix Node Autocomplete Regressions Due that we are adding ZeroTouchNodes during test mode around 9 tests are failing, seems that there are several nodes duplicates so each test needs to be analyzed separately. Then in this fix I'm reverting the code for adding ZeroTouchNodes and also removing a test that will fail due to this change. * Fix Node Autocomplete Regressions Re-adding unit test with Failure category
QilongTang
pushed a commit
that referenced
this pull request
Aug 24, 2023
* Fix Node Autocomplete Regressions (#14275) * Fix Node Autocomplete Regressions Due that we are adding ZeroTouchNodes during test mode around 9 tests are failing, seems that there are several nodes duplicates so each test needs to be analyzed separately. Then in this fix I'm reverting the code for adding ZeroTouchNodes and also removing a test that will fail due to this change. * Fix Node Autocomplete Regressions Re-adding unit test with Failure category * DYN-6148 Dynamo Library Lucene Search (#14287) * DYN-6148 Dynamo Library Lucene Search Implementing the use of Lucene Search in the Dynamo Library * DYN-6148 Dynamo Library Lucene Search Fixing calls to LuceneSearchUtility for using the Lucene Singleton. * DYN-6148 Dynamo Library Lucene Search Removing extra space and removing unused usings * DYN-6148 Dynamo Library Lucene Search Regressions The SearchNodeTest() test was moved to DynamoLibraryItemsTest due that in the LibraryResourceProviderTests we are not creating the DynamoModel (also there is no way to get the DynamoModel) so the Lucene Singleton is not created and is crashing. Also I did some minor changes in the test due that the FullName contains the category (so instead of "dyf://123.456.somepackage.{nodeName}" was replaced by "dyf://Core.Input.{nodeName}" otherwise the Code Block node is not found).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing regressions related to Node Autocomplete
Due that we are adding ZeroTouchNodes during test mode 9 tests are failing, seems that there are several nodes duplicated so each test needs to be analyzed separately. Then in this temporary fix I'm reverting the code for adding ZeroTouchNodes and also removing a test that will fail due to this change.
Later we will need to check why we are getting duplicates when adding ZeroTouchNodes and re-add the deleted test that check that the nodes "+", "*", "And", "Or" exists in InCanvasSearch.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing regressions related to Node Autocomplete
Reviewers
@QilongTang
FYIs