Pm mypackages - cherrypick animation screen #14270

dnenov · 2023-08-16T09:51:11Z

Cherry-pick from #14198 to break it down into smaller chunks.

Purpose

This is a follow-up PR on the package integration PR. It builds on the continuous design guides as per this Figma link.

Even though a lot of areas have been improved, this is still work in progress. With the main skeleton of the solution in place, the major directions of work are:

design changes in Search for packages tab
design changes in Publish a package tab
design changes in My packages tab
design changes in Publish version tab

Screenshots

01 loading screen

02 discard loading timeout

03 package details extension interaction

04 package manager contents

05 package manager to preferences interaction

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

Progression work on the Package Manager

interactions between different parts of the package manager and between package manager and preferences screen
added empty, loading, idle screens
work on the PacakgeDetailsExtension to allow hosting inside the PackageManager
misc refactor

Reviewers

@reddyashish
@QilongTang

FYIs

@Amoursol

- added MyPackages controll - added warning navigation screen when no local packages are installed

- now populates separately and is not linked to SearchResults (not influenced by search changes)

- added the loading animation screen (still WIP) - connected controls and visibility binding - since this particular animation cannot be set in style, created custom control for the loading stripe

- getting the UI as close to the initial design as possible

- removed unused namespaces - static to non-static namespace

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

src/DynamoCoreWpf/Views/PackageManager/Controls/PackageManagerPackagesControl.xaml.cs

reddyashish · 2023-08-16T13:13:10Z

LGTM with some comments.

- removed line where we were setting DynamoView owner to the pkg manager window - refactored code removing reference to PackageManagerSearchViewModel inside the PackageManagerPackagesControl.xaml.cs

src/DynamoCoreWpf/UI/Converters.cs

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

- removed null check not working

- changed sorting order

dnenov added 5 commits August 16, 2023 10:21

MyPackages, Installed Packages empty screen

e3a2c56

- added MyPackages controll - added warning navigation screen when no local packages are installed

SearchMyResults collection changed

00ebb9e

- now populates separately and is not linked to SearchResults (not influenced by search changes)

Loading animation screen

ba04d8f

- added the loading animation screen (still WIP) - connected controls and visibility binding - since this particular animation cannot be set in style, created custom control for the loading stripe

UI Tweaks

8d11f30

- getting the UI as close to the initial design as possible

clean up

49d68d2

- removed unused namespaces - static to non-static namespace