-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6052 Add node info event and API under DynamoServices package for ProtoCore #14234
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cadd563
Add node info event and API
QilongTang 83e8940
Update
QilongTang bd490ac
Update
QilongTang e242e03
clean up
QilongTang 40cdf23
remove line and column from InfoEntry
QilongTang 489fa44
comments
QilongTang 626c0c1
clean up
QilongTang 8fd7999
clean up
QilongTang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
using System; | ||
using System; | ||
|
||
namespace DynamoServices | ||
{ | ||
|
@@ -12,6 +12,19 @@ public LogWarningMessageEventArgs(string msg) | |
} | ||
} | ||
|
||
/// <summary> | ||
/// EventArgs for LogInfoMessageEventHandler | ||
/// </summary> | ||
public class LogInfoMessageEventArgs : EventArgs | ||
{ | ||
public string message { get; internal set; } | ||
|
||
public LogInfoMessageEventArgs(string msg) | ||
{ | ||
message = msg; | ||
} | ||
} | ||
QilongTang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
public delegate void LogWarningMessageEventHandler(LogWarningMessageEventArgs args); | ||
|
||
public static class LogWarningMessageEvents | ||
|
@@ -24,6 +37,18 @@ public static void OnLogWarningMessage(string message) | |
} | ||
} | ||
|
||
public delegate void LogInfoMessageEventHandler(LogInfoMessageEventArgs args); | ||
|
||
public static class LogInfoMessageEvents | ||
{ | ||
public static event LogInfoMessageEventHandler LogInfoMessage; | ||
public static void OnLogInfoMessage(string message) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the new API ProtoGeometry will call to raise info instead of warning |
||
{ | ||
if (LogInfoMessage != null) | ||
LogInfoMessage(new LogInfoMessageEventArgs(message)); | ||
} | ||
} | ||
|
||
internal static class LoadLibraryEvents | ||
{ | ||
/// <summary> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we didn’t have to expose more APIs from the engine level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did look at it but unfortunately because the current
public interface ILiveRunner
setup, the function involved needs to be public and also the return object as well. VS does throw errors if trying to make this internal. I have made as much as I can internal or privateThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really a good candidate for a struct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://learn.microsoft.com/en-us/dotnet/standard/design-guidelines/choosing-between-class-and-struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjkkirschner I am not sure but maybe we could break these changes in 3.0. Right now I am just following the previous design for all these engine related code