feat(DYN-5976): add forward delete functionality #14217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Aug 2, 2023
| @@ -347,6 +348,7 @@ private void Browser_CoreWebView2InitializationCompleted(object sender, CoreWebV | |||
| //The default value of the zoom factor is 1.0. The value that comes from the slider is in percentage, so we divide by 100 to be equivalent | |||
| browser.ZoomFactor = (double)dynamoViewModel.Model.PreferenceSettings.LibraryZoomScale / 100; | |||
| browser.ZoomFactorChanged += Browser_ZoomFactorChanged; | |||
| browser.KeyDown += Browser_KeyDown; | |||
There was a problem hiding this comment.
Please unsubscribe at protected void Dispose(bool disposing) function to avoid memory leak
|
@Enzo707 Can you take another look at DynamoDS/librarie.js#185? |
QilongTang
approved these changes
Aug 3, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR implements the forward delete functionality as webview2 doesn't support Accelerator keys
DYN-5976
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Implements forward delete functionality for searchBar input in librariejs and the mechanism in dynamo to "binding" accelerator keys that are not supported in webview2.
In other words we track accelerator keys in Dynamo and use javascript dispatchEvent method to trigger the librariejs event that execute the forward delete method.
Reviewers
@QilongTang
FYIs
@RobertGlobant20