Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageManager Lucene Crash #14179

Merged
merged 2 commits into from
Jul 21, 2023
Merged

PackageManager Lucene Crash #14179

merged 2 commits into from
Jul 21, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fixing crash after opening and closing the PackageManager
After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called). Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing crash after opening and closing the PackageManager

Reviewers

@QilongTang @reddyashish

FYIs

After opening the Package Manager and closing it was crashing due that the LuceneSearchUtility.Writer was null (the second time we don't reach the PackageManagerSearchViewModel constructor so the InitializeLuceneConfig() was not called).
Then for this fix if the PackageManagerSearchViewModel was already created then we have to call again the InitializeLuceneConfig().
@reddyashish
Copy link
Contributor

Looks like there is a failure @RobertGlobant20 ?

@RobertGlobant20
Copy link
Contributor Author

Looks like there is a failure @RobertGlobant20 ?

@reddyashish seems that there is a problem when parsing the DynamoCoreTestResults.xml file, I don't think this is related to this fix, right?.
image

@reddyashish
Copy link
Contributor

reddyashish commented Jul 20, 2023

yeah, can you trigger a rebuild

Removing empty space
@QilongTang
Copy link
Contributor

@reddyashish @RobertGlobant20 it was a build time out issue, I discussed with Turbo team this morning and we raised the limit

@RobertGlobant20
Copy link
Contributor Author

@QilongTang @reddyashish most of the checks passed, the only one Pending is SonarQube Scan, not sure why is Pending if I cannot see any task runing for DynamoCACoverage job

@QilongTang QilongTang merged commit d037ae2 into DynamoDS:master Jul 21, 2023
@QilongTang QilongTang added this to the 2.19.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants