Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation browser error message fix #14174

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jul 18, 2023

Purpose

This PR fixes an issue with the Documentation Browser specifically when displaying a Warning without an "href" tag. Previously, when creating the Warning message part of the help body, we would assume that an "href" tag is present in the second line of the info message. This is not always the case, and as a result any warning message of more than 1 line would be clipped to display only the first line.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • a small fix around a limitation in how warnings were read
  • now captures the case where a warning does not have an href tag to it
  • will now display the full multiline text of a warning that does not have an href tag

Reviewers

@Amoursol

FYIs

@reddyashish

- a small fix around a limitation in how warnings were read
- now captures the case where a warning does not have an href tag to it
- will now display the full multiline text of a warning that does not have an href tag
@QilongTang QilongTang added this to the 2.19.0 milestone Jul 18, 2023
@Amoursol
Copy link
Contributor

@reddyashish a small PR from Deyan adding multi-line support to Error Messages in the Extended Node Help.

@QilongTang QilongTang merged commit 4228417 into DynamoDS:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants