Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6058 - UI changed location for Package Download toast #14173

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jul 18, 2023

Purpose

This is a small UI fix to the Search for packages window. When a package is downloaded, a (toast) notification is shown in the bottom row of the window. This row was observed to have started displaying a bit higher than it should. This PR addressed the issue.

Jira task

Figma link

UI Snapshot

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Removed margin bottom offsets to the last 2 grid rows as to lessen the amount of offset the Toast row is pushed up from the bottom of the window. The figma mock-up shows a thick gray bottom line which partly hides the gap - that line is not to be implemented, though, and was present in the figma document by mistake (checked with the team). 

Reviewers

@avidit

FYIs

@reddyashish
@Jingyi-Wen

- removed bottom margins to last 2 rows of the grid
@QilongTang QilongTang merged commit fb033b0 into DynamoDS:master Jul 18, 2023
sm6srw added a commit to sm6srw/Dynamo that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants