Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration Assistant visual refresh #14145

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Migration Assistant visual refresh #14145

merged 2 commits into from
Jul 10, 2023

Conversation

reddyashish
Copy link
Contributor

Purpose

Task: https://jira.autodesk.com/browse/DYN-5903

Visual refresh of Migration Assistant

Screenshot 2023-07-10 at 9 58 03 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Migration Assistant visual refresh

Reviewers

@QilongTang @RobertGlobant20

@QilongTang QilongTang added this to the 2.19.0 milestone Jul 10, 2023
QilongTang
QilongTang reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one commet

@reddyashish
Copy link
Contributor Author

2 Flaky tests: WorkspaceContextMenu_TestIfOpenOnRightClick and ASM loading exception on AggregateRenderPackagesDoesntMutateRenderPackage.

@reddyashish reddyashish merged commit 8d29c5a into DynamoDS:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@reddyashish @QilongTang