Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.16.2 Hot Fix #14116

Merged
merged 3 commits into from
Jul 6, 2023
Merged

2.16.2 Hot Fix #14116

merged 3 commits into from
Jul 6, 2023

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 28, 2023 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Cherry-picking #13348 and make version changes for the hotfix branch,

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

QilongTang and others added 2 commits June 28, 2023 15:03
@QilongTang
version changes
c8a98bd
@mjkkirschner @QilongTang
fix slider localization bug (#13348)
86b22ef 
* fix slider localization bug
add test

* comment

Co-authored-by: kirschm <[email protected]>
@QilongTang QilongTang changed the title Hot fix 2.16.2 Hot fix Jun 28, 2023
@QilongTang QilongTang changed the title 2.16.2 Hot fix 2.16.2 Hot Fix Jun 28, 2023
@QilongTang QilongTang changed the base branch from RC2.16.1_master to RC2.16.2_master June 28, 2023 21:21
@QilongTang
Copy link
Contributor Author

@mjkkirschner Can you take a look at this PR, is the cherry-picked PR the only change needed? I saw some regressions when running self serve

@mjkkirschner
Copy link
Member

@QilongTang - which self serve are you referring to - master-5 or master-15?

@QilongTang QilongTang merged commit 5d62f59 into RC2.16.2_master Jul 6, 2023
@QilongTang QilongTang deleted the HotFix branch July 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeusongit zeusongit zeusongit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QilongTang @mjkkirschner @zeusongit