Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5821-AddToWorkspace-DocumentationBrowser #14103

Merged
merged 1 commit into from
Jun 22, 2023
Merged

DYN-5821-AddToWorkspace-DocumentationBrowser #14103

merged 1 commit into from
Jun 22, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Preventing crash when inserting xml dyn graph files into workspace.
I've added some validations so when we are trying to insert a xml dyn file graph without notes, inserting doesn't crash (otherwise the graph is not added).

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Preventing crash when inserting xml dyn graph files into workspace.

Reviewers

@QilongTang @reddyashish

FYIs

I've added some validations so when we are trying to insert a xml dyn file graph without notes, inserting doesn't crash (otherwise the graph is not added).
@RobertGlobant20
Copy link
Contributor Author

GIF showing that is inserting the graph for the Math.Floor node (previously it was not doing anything).
InsertingFloorGraph

@QilongTang QilongTang added this to the 2.19.0 milestone Jun 22, 2023
@QilongTang QilongTang merged commit bd96192 into DynamoDS:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants