Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Group Styles section #14079

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix Group Styles section #14079

merged 1 commit into from
Jun 15, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fix in Group Styles section for showing styles added correctly
In a previous fix a vertical scrollbar was added generating that the GroupStyles items added are shown in only one column (previously two columns) so in this fix I'm reducing the width so two group styles are shown again in two columns.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix in Group Styles section for showing styles added correctly

Reviewers

@QilongTang

FYIs

@avidit

In a previous fix a vertical scrollbar was added generating that the GroupStyles items added are shown in only one column (previously two columns) so in this fix I'm reducing the width so two group styles are shown again in two columns.
@RobertGlobant20
Copy link
Contributor Author

Screenshot showing how it looks after my fix:
FixingGroupStylesTwoColumns

@QilongTang QilongTang added this to the 2.19.0 milestone Jun 15, 2023
@QilongTang QilongTang merged commit 0ba6fa3 into DynamoDS:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants