Border to PreferenceView

[dnenov]

Purpose

A visual update to the Preferences View adding a white (WorkspaceBackgroundHomeBrush) 2px border. This should increase the visibility of the control and make it easier for users to make out the actual window when overlapping with other UI elements.

Screenshot of changes

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

• added white border to preference view to increase visibility

Reviewers

@Amoursol
@reddyashish
@QilongTang

FYIs

[QilongTang]

The reported regression is sporadic failure
DynamoCoreWpfTests.CoreUserInterfaceTests.WorkspaceContextMenu_TestIfOpenOnRightClick

[QilongTang]

I guess you happen to found out this color from other places is white?

[dnenov]

I got this one from the NodeView border

Dynamo/src/DynamoCoreWpf/Views/Core/NodeView.xaml

Line 569 in b02d034

BorderBrush="{StaticResource WorkspaceBackgroundHomeBrush}"

as instructed by @Amoursol. The only thing is the borderthickness, which for the Nodes is 1px, and for the PreferencesView is now set at 2px. I will double-check with @Amoursol to see if there is preference for each maybe.

[QilongTang]

Thanks, will merge it for now