Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Default Name format to save image #14068

Closed
wants to merge 1 commit into from

Conversation

chuongmep
Copy link
Contributor

@chuongmep chuongmep commented Jun 13, 2023

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

I want update save image should be become come just name of script, no include date time after.

Why I do this ?

  • Let see, my Package need Save image for 1000 Script with origin name of Script, I need to remove date time every time file name to update, can't override correctly, In case user want save image with some picture, I believe it is not problem with them if they can add for them self.

Let see preview my problem, my package needs to save for more than 1000 image with correct name of script, and after that it automation deploy in web : https://chuongmep.github.io/OpenMEP/api/OpenMEPRevit.Element.CableTray.html

ảnh

Let say, I have one script, I just need to save correct name of this script :
ảnh

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@Amoursol

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@Amoursol
Copy link
Contributor

@QilongTang any thoughts on how we can help @chuongmep with his issue, but not affect current users who use this feature for things like Generative Studies that do require date-time stamping?

@QilongTang
Copy link
Contributor

@Amoursol I would prefer making this part of preferences instead of touching the default name, maybe a checkbox to include timestamp?

@Amoursol
Copy link
Contributor

@Amoursol I would prefer making this part of preferences instead of touching the default name, maybe a checkbox to include timestamp?

Agreed @QilongTang 😄

@chuongmep would you be interested in amending your PR to make it an option, situated inside the Preferences Panel? If so please put it under "General" and use a button similar to the "Pause Splash Screen" to toggle use of DateTime suffix or not.

image

@QilongTang
Copy link
Contributor

@chuongmep Let us know if you are comfortable making that change, or our team can take over this PR

@chuongmep
Copy link
Contributor Author

I agree with that if this change affect to another process like generative design and some user

@QilongTang
Copy link
Contributor

@chuongmep I am taking over and working on this

@QilongTang
Copy link
Contributor

Closing this PR in favor of #14082

@QilongTang QilongTang closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants