Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference Greg Version 2.5.0.5076 which has a dotnet 6 target #14025

Merged
merged 2 commits into from
May 25, 2023
Merged

Reference Greg Version 2.5.0.5076 which has a dotnet 6 target #14025

merged 2 commits into from
May 25, 2023

Conversation

Cristhian-Marin-asdk
Copy link
Collaborator

Purpose

Upgrade Greg Client package to 2.5.0.5076 which now has a dotnet 6 target

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Upgrade Greg Version to 2.5.0.5076

Reviewers

FYIs

mjkkirschner
mjkkirschner approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. lets wait for the tests
  2. one change request
    otherwise LGTM

JimmySanchezGlobant
JimmySanchezGlobant approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@JimmySanchezGlobant JimmySanchezGlobant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjkkirschner mjkkirschner merged commit d4027c8 into DynamoDS:master May 25, 2023
@Cristhian-Marin-asdk Cristhian-Marin-asdk deleted the DYN-5914-Upgrade-GregClient-Version branch June 9, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmySanchezGlobant JimmySanchezGlobant JimmySanchezGlobant approved these changes

@mjkkirschner mjkkirschner mjkkirschner approved these changes

@jasonstratton jasonstratton Awaiting requested review from jasonstratton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cristhian-Marin-asdk @mjkkirschner @JimmySanchezGlobant