Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TabFolding edge-case inside python editor. #14004

Merged
merged 1 commit into from
May 18, 2023

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented May 18, 2023

Purpose

As per the crash reported here: https://forum.dynamobim.com/t/dynamo-2-18-release/89667/3, this check should fix the edge case. Will be cherrypicking into 2.18.1 hotfix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Handle TabFolding edge-case inside python editor.

Reviewers

@QilongTang @dnenov

Copy link
Collaborator

@dnenov dnenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end, fixes the crash!

@zeusongit zeusongit added this to the 2.18.1 milestone May 18, 2023
@QilongTang QilongTang merged commit 054ef8c into DynamoDS:master May 18, 2023
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request May 18, 2023
reddyashish added a commit that referenced this pull request May 18, 2023
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants