Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5657 - Insert shortcut change #13995

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 16, 2023

Purpose

A tiny PR changing the shortcut for Insert command. Ctrl + I has traditionally been used for the Isolate command. Insert now uses Ctrl + Shift + I instead. This Jira task was dedicated on the issue.

insert shortcut

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • changed the shortcut combination for the Insert command
  • now uses Ctrl + Shift + I instead of Ctrl + I

Reviewers

@Amoursol
@reddyashish

FYIs

- changed the shortcut combination for the Insert command
- now uses Ctrl + Shift + I instead of Ctrl + I
@QilongTang QilongTang added this to the 2.19.0 milestone May 16, 2023
@reddyashish
Copy link
Contributor

@reddyashish reddyashish merged commit 1c599af into DynamoDS:master May 16, 2023
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request May 17, 2023
- changed the shortcut combination for the Insert command
- now uses Ctrl + Shift + I instead of Ctrl + I

(cherry picked from commit 1c599af)
@reddyashish reddyashish mentioned this pull request May 17, 2023
9 tasks
QilongTang pushed a commit that referenced this pull request May 18, 2023
* Insert shortcut change (#13995)

- changed the shortcut combination for the Insert command
- now uses Ctrl + Shift + I instead of Ctrl + I

(cherry picked from commit 1c599af)

* class keyword designscript align (#13998)

- aligned class keyword color to python

(cherry picked from commit dcea09c)

---------

Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants