Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyn 5444 splash screen keyboard #13989

Merged
merged 7 commits into from
May 12, 2023
Merged

Dyn 5444 splash screen keyboard #13989

merged 7 commits into from
May 12, 2023

Conversation

jesusalvino
Copy link
Contributor

Purpose

Removing and defending the handling of the keyboard in Dynamo, it will be handled in the SplashScreen React project as part of the improvement https://jira.autodesk.com/browse/DYN-5444

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@QilongTang
@reddyashish

FYIs

@RobertGlobant20
@Enzo707

@jesusalvino
Copy link
Contributor Author

ss_Final

@reddyashish reddyashish merged commit 23aca1a into DynamoDS:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants