Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5844-ColorPicker-MarginIssues #13986

Merged
merged 1 commit into from
May 12, 2023
Merged

DYN-5844-ColorPicker-MarginIssues #13986

merged 1 commit into from
May 12, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fixing height value for CustomColorPicker.
We have a Canvas inside a Grid but the Canvas doesn't support auto-size like other WPF controls then the only way to fix the problem of the CustomColorPicker appearing wrong under a 200% scale is to use a fixed height. In this way this fix will make the NormalColors window with the same height than the CustomColors window.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing height value for CustomColorPicker.

Reviewers

@QilongTang

FYIs

We have a Canvas inside a Grid but the Canvas doesn't support auto-size like other WPF controls then the only way to fix the problem of the CustomColorPicker appearing wrong under a 200% scale is to use a fixed height.
In this way this fix will make the NormalColors window with the same height than the CustomColors window.
@RobertGlobant20
Copy link
Contributor Author

Screenshot showing how it looks
ColorPickerHeightFix

@QilongTang QilongTang added this to the 2.19.0 milestone May 12, 2023
@reddyashish
Copy link
Contributor

Failing test is a flaky one: WorkspaceContextMenu_IfSubmenuOpenOnMouseHover

@reddyashish reddyashish merged commit 0990de5 into DynamoDS:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants