Dyn 5444 splash screen keyboard

[jesusalvino]

Purpose

Implementing the improvement https://jira.autodesk.com/browse/DYN-5444

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Reviewers

@QilongTang

FYIs

@reddyashish
@RobertGlobant20
@Enzo707

[jesusalvino]

[QilongTang]

Can user dismiss splash screen by pressing Ecs?

[jesusalvino]

Can user dismiss splash screen by pressing Ecs?

yes @QilongTang , we can catch when the user press Esc once the Splash Screen is ready, Do you mean to intercept it and Lunch the application (Dismiss) ?

[QilongTang]

Hi @jesusalvino If you check the second AC of the Jira task, it includes that catching key press to exit splash screen. For now, I would like to simply include that When user press Esc at the static splash screen, Dynamo exit, which is equivalent of pressing the cross on the top right corner. Let me know if that make sense to you

[jesusalvino]

Hi @jesusalvino If you check the second AC of the Jira task, it includes that catching key press to exit splash screen. For now, I would like to simply include that When user press Esc at the static splash screen, Dynamo exit, which is equivalent of pressing the cross on the top right corner. Let me know if that make sense to you

@QilongTang Done.

[QilongTang]

LGTM

[reddyashish]

@QilongTang Do we want to close dynamo when user presses esc or just lose focus from the screen? Generally imo, closing the app is not the behavior expected when user presses esc.

[QilongTang]

@QilongTang Do we want to close dynamo when user presses esc or just lose focus from the screen? Generally imo, closing the app is not the behavior expected when user presses esc.

Usually Esc is for calling out the main menu in App, but we dont have that for splash screen, I believe the user request behind the Jira task was to quit Splash screen. In terms of what it should do in Dynamo, we need to discuss and implement later. let me know if it make sense.

[reddyashish]

Sorry Aaron, I was referring to closing the splash screen only by hitting escape. Alt+f4 is used to close any window app, so i was thinking esc should just lose focus of the screen. Is that requested from a customer?
Changes look good to me, we can merge this if that behavior is fine.

[QilongTang]

Sorry Aaron, I was referring to closing the splash screen only by hitting escape. Alt+f4 is used to close any window app, so i was thinking esc should just lose focus of the screen. Is that requested from a customer? Changes look good to me, we can merge this if that behavior is fine.

Thank you @reddyashish this is a good thing to clarify. I believe this is a request logged by @avidit and from our discussion, we would like to have shortcuts to Splash Screen (just like Dynamo) starting from Exit. Naturally, I picked Esc because of the common definition below. Alt + F4 sounds also good but that is not ppl usually do since it is more of a forcing function to close when the application is not responsive or the user does not have any data they would like to save/keep.

[reddyashish]

Thank you Aaron, sounds good. The 2 tests failing here are flaky and LGTM.