DYN-4490-PythonScriptFromString_NodeFix #13958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the location of the engine label in the PythonScriptFromString node. I've used the normal nodeView.grid for addnig the engineLabel instead of the nodeView.PresentationGrid due that this last one is located in a different row, column.
|
GIF showing the label in the expected place. |
QilongTang
reviewed
Apr 28, 2023
| engineLabel.HorizontalAlignment = HorizontalAlignment.Left; | ||
| engineLabel.VerticalAlignment = VerticalAlignment.Bottom; | ||
| engineLabel.Margin = new Thickness(14, -4, -10, 4); | ||
| Canvas.SetZIndex(engineLabel, 5); |
There was a problem hiding this comment.
Are these similar to how Python Script node is setting the label location?
There was a problem hiding this comment.
yes, is almost a copy-paste.
QilongTang
approved these changes
May 1, 2023
|
The reported regression is a sporadic one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing the location of the engine label in the PythonScriptFromString node.
I've used the normal nodeView.grid for addnig the engineLabel instead of the nodeView.PresentationGrid due that this last one is located in a different row, column.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing the location of the engine label in the PythonScriptFromString node.
Reviewers
@QilongTang
FYIs