Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python editor docking and undocking #13957

Merged
merged 15 commits into from
May 10, 2023
Merged

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Apr 28, 2023

Purpose

Python editor docking and undocking. https://jira.autodesk.com/browse/DYN-3393

DockWindowInSideBar() is introduced to dock a window to the right side bar.
UndockWindow() is to undock a tab from the right side bar and call the necessary action to launch the original window.

python docking new

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Python editor docking and undocking

Reviewers

@QilongTang @zeusongit

@QilongTang
Copy link
Contributor

I feel like we need a slightly larger dock icon on Python editor? @Jingyi-Wen

@Jingyi-Wen
Copy link

I feel like we need a slightly larger dock icon on Python editor? @Jingyi-Wen

Hmm, this does look weird. Let me make a bigger one.
Also, I'd suggest putting this icon in between the minimize and maximize.

@Jingyi-Wen
Copy link

Dock_32px_hover
Dock_32px_default

@zeusongit zeusongit added this to the 2.19.0 milestone May 3, 2023
@reddyashish
Copy link
Contributor Author

Updated the changes with new icon and fixed editor functionality when it is docked. Working on tests now.

@QilongTang
Copy link
Contributor

There was one edge case from demo where the Python Script node renamed in canvas, would the tab name also renamed?

@reddyashish
Copy link
Contributor Author

reddyashish commented May 9, 2023

@QilongTang The tab name is based on the node name but it won't rename the tab if it is docked. When the tab is opened again, it will have the new node name. Do you expect it to rename when it is docked?

@QilongTang
Copy link
Contributor

@QilongTang The tab name is based on the node name but it won't rename the tab if it is docked. When the tab is opened again, it will have the new node name. Do you expect it to rename when it is docked?

This probably can be follow up task. But I expect the name in sync

@reddyashish
Copy link
Contributor Author

one failing test. Looking into it.

@reddyashish
Copy link
Contributor Author

reddyashish commented May 9, 2023

Fixed an edge case, edit context menu on the script now works fine when docked.
Running the tests again.

@reddyashish reddyashish merged commit 30fae15 into DynamoDS:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants