-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python editor docking and undocking #13957
Conversation
I feel like we need a slightly larger dock icon on Python editor? @Jingyi-Wen |
Hmm, this does look weird. Let me make a bigger one. |
Updated the changes with new icon and fixed editor functionality when it is docked. Working on tests now. |
There was one edge case from demo where the Python Script node renamed in canvas, would the tab name also renamed? |
@QilongTang The tab name is based on the node name but it won't rename the tab if it is docked. When the tab is opened again, it will have the new node name. Do you expect it to rename when it is docked? |
This probably can be follow up task. But I expect the name in sync |
one failing test. Looking into it. |
Fixed an edge case, edit context menu on the script now works fine when docked. |
Purpose
Python editor docking and undocking. https://jira.autodesk.com/browse/DYN-3393
DockWindowInSideBar() is introduced to dock a window to the right side bar.
UndockWindow() is to undock a tab from the right side bar and call the necessary action to launch the original window.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Python editor docking and undocking
Reviewers
@QilongTang @zeusongit