Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust location warning mis-display after adjusting zoom scale #13921

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 21, 2023

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per https://jira.autodesk.com/browse/DYN-5818, On editing Python zoom scale, current workspace under trusted file path needs to be re-trusted. Fixing this as part of 2.18 release by correcting director of current workspace during the sanity check.

After:
TrustLocationWarning

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 2.18.0 milestone Apr 21, 2023
@QilongTang QilongTang marked this pull request as ready for review April 21, 2023 18:03
@QilongTang QilongTang merged commit 0b23931 into master Apr 24, 2023
@QilongTang QilongTang deleted the TrustLocationWarning branch April 24, 2023 14:46
@QilongTang QilongTang restored the TrustLocationWarning branch April 24, 2023 15:17
QilongTang added a commit that referenced this pull request Apr 24, 2023
@QilongTang QilongTang mentioned this pull request Apr 24, 2023
9 tasks
reddyashish pushed a commit that referenced this pull request Apr 24, 2023
@QilongTang QilongTang deleted the TrustLocationWarning branch May 10, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants