Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dyn 5716 color picker improvements #13919

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Dyn 5716 color picker improvements #13919

merged 3 commits into from
Apr 24, 2023

Conversation

jesusalvino
Copy link
Contributor

Purpose

Implementing the improvement https://jira.autodesk.com/browse/DYN-5716

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@QilongTang

FYIs

@RobertGlobant20
@Enzo707

@jesusalvino
Copy link
Contributor Author

jesusalvino commented Apr 20, 2023 •
edited
Loading

Before

before-2

After

after-2

Behavior

CoreNodeModels Input ColorPalette_img

@reddyashish
Copy link
Contributor

reddyashish commented Apr 21, 2023 •
edited
Loading

@jesusalvino LGTM. A couple of suggestions:
Padding of the "Color" title. The text is more towards the the top border.
Left margin of the titles doesn't look aligned. I could be wrong. just check.
Looks like there is more space between the "Custom colors" and button. Keep it same like the Basic colors.

@reddyashish reddyashish added this to the 2.18.0 milestone Apr 21, 2023
@jesusalvino
Copy link
Contributor Author

jesusalvino commented Apr 21, 2023 •
edited
Loading

@jesusalvino LGTM. A couple of suggestions: Padding of the "Color" title. The text is more towards the the top border. Left margin of the titles doesn't look aligned. I could be wrong. just check. Looks like there is more space between the "Custom colors" and button. Keep it same like the Basic colors.

sure @reddyashish , I will clean them. @Jingyi-Wen your thoughts please

@jesusalvino
Copy link
Contributor Author

@reddyashish just updated

@QilongTang QilongTang merged commit bd949a8 into DynamoDS:master Apr 24, 2023
@QilongTang
Copy link
Contributor

@jesusalvino Please cherry-pick this to the RC2.18.0_master branch

QilongTang pushed a commit that referenced this pull request Apr 24, 2023
@jesusalvino
Cherry-Picking the ColorPicker to the 2.18 (#13932)
0ac6595 
* Dyn 5716 color picker improvements (#13919)

* Color Picker UI improvements

* Updating documentation

* Fixing pixels

* Update the gif doc (#13930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jesusalvino @reddyashish @QilongTang