Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Python Port Properties - bugfix #13915

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Edit Python Port Properties - bugfix #13915

merged 1 commit into from
Apr 21, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 19, 2023

Purpose

A small bugfix to Edit Port Properties inport context menu. Used to be displayed for any Node, now only shows for Python nodes, as required.

Changes

inport-before-after

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixed the condition in which the Edit Port Properties will be visible for all Nodes

Reviewers

@reddyashish
@Amoursol

@dnenov
Update InPortContextMenu.xaml
5ae8253 
- fixed the condition in which the Edit Port Properties will be visible for all Nodes
@QilongTang QilongTang added this to the 2.18.0 milestone Apr 19, 2023
@reddyashish
Copy link
Contributor

Running the job again: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8915/

@reddyashish
Copy link
Contributor

Job passed. Merging this and will cherry-pick it

@reddyashish reddyashish merged commit 36f1531 into DynamoDS:master Apr 21, 2023
reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request Apr 21, 2023
@dnenov @reddyashish
Update InPortContextMenu.xaml (DynamoDS#13915)
b7c1230 
- fixed the condition in which the Edit Port Properties will be visible for all Nodes

(cherry picked from commit 36f1531)
@reddyashish reddyashish mentioned this pull request Apr 21, 2023
Merged
9 tasks
reddyashish added a commit that referenced this pull request Apr 21, 2023
@reddyashish @dnenov
Update InPortContextMenu.xaml (#13915) (#13920)
59d5656 
- fixed the condition in which the Edit Port Properties will be visible for all Nodes

(cherry picked from commit 36f1531)

Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnenov @reddyashish @QilongTang