better error messages for ZT import failure #13911
Conversation
| @@ -171,8 +171,8 @@ private static FlowDocument GetCustomDocument(string Text) | |||
| imageFig.Height = new FigureLength(30); | |||
| para.Inlines.Add(imageFig); | |||
| } | |||
| //End fo the Bullet Items formatting | |||
| if (word.EndsWith("-")) | |||
| //End of the Bullet Items formatting | |||
There was a problem hiding this comment.
honestly, I'm not sure what this comment is trying to get across but I think it's supposed to be of - @RobertGlobant20 any hints?
There was a problem hiding this comment.
Well is referring that if you find the next text inside the CustomRichTextBox
- Bullet number 1 asdfasdfasdfasdfasdfasdfasfdasdfasfasfdasfasfdasdfasfdas -
it will put a bullet at the beginning and is expecting the "-" at the end so we will know which text should be included.
- Bullet number 1 asdfasdfasdfasdfasdfasdfasfdasdfasfasfdasfasfdasdfasfdas
yes, I agree it should be "of"
|
@mjkkirschner You may also consider merging in and have test in a new PR, your choice. |
there are 1500 failing tests - looks like something went wrong with the resx generation for localized strings... looking into it. |
|
I'm going to hold merging this until the tests pass - might be awhile as the build machines are down. 😢 |
this passed on serial tests and https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8868/ - merging * better error messages and fix some bugs and ui * comment * small change * expose some methods for testing
this passed on serial tests and https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8868/ - merging * better error messages and fix some bugs and ui * comment * small change * expose some methods for testing
Purpose
addresses part of https://jira.autodesk.com/browse/DYN-5506
There are a lot of whitespace changes because I added some giant try/catch statements - please review with white space diff off.
TODO
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of