-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-5782-PrePopulate-CustomColorPicker #13903
DYN-5782-PrePopulate-CustomColorPicker #13903
Conversation
This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles). This fix is not applicable for the Color Palette node.
Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel? |
@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles). |
Understood, I think both cases are what customer asked, please give it a check. Thanks! |
This fix will be pre-populating the custom colors in CustomColorPicker (when opened from the Color Palette node) with the colors added in the Preferences->GroupStyles section. Also I've added a unit test that will be validating that the custom colors list used by ColorPicker is populated correctly with the color loaded from Group Styles
@QilongTang functionality added for the Color Palette node and I've added a unit test. Thanks |
Purpose
This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles). This fix is not applicable for the Color Palette node.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section.
Reviewers
@QilongTang
FYIs