Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PortToConnect correctly, when same node recommendations are returned from ML API #13899

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

reddyashish
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-5645

Now the correct port is connected when same node recommendations are returned from ML API. The results are displayed as list box and not as menu items. So we won't be able to provide sub menu functionality.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Handle PortToConnect correctly, when same node recommendations are returned from ML API

Reviewers

@QilongTang

FYIs

@DynamoDS/dynamo

@QilongTang
Copy link
Contributor

Hi @reddyashish Is this PR just for the bug that clicking on each entry will connect to the right port instead? you mentioned that we cant implement the UI changes for sub menu items correct?

@reddyashish
Copy link
Contributor Author

Yes, just for that bug.

1 similar comment
@reddyashish
Copy link
Contributor Author

Yes, just for that bug.

@reddyashish
Copy link
Contributor Author

@QilongTang Only 1 flaky test now InsideCustomNode_NotPlacedInHomeWorkspace_NoGeometry.

@QilongTang
Copy link
Contributor

@reddyashish And we are still not sure which PR caused that flaky test right? Are you fine with Morpheus team merging PRs with new flaky tests? @mjkkirschner @sm6srw or would you rather us investigate this a bit more?

@reddyashish
Copy link
Contributor Author

reddyashish commented Apr 13, 2023

Yeah not sure yet. Lets see the results from Mike's PR #13900, if any test fails

@QilongTang QilongTang merged commit 1ba5f3f into DynamoDS:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants