-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename some long documentation files and add more logging to rename command. #13894
Conversation
not sure I understand this fully:
So you renamed some content (.dyn) from some long name to a GUID based name. These renamed files have been added to git. |
Some hosts have already included these longs file names in their installers so we need to keep them around until next RTM (requirement for the old patch installer, we can't remove files). This is hopefully the last time we need to do this (keep the files around, that is). The new patch installer does not have this limitation. In general, I think I am on Mike's side that we should find a better way to do this. Maybe check with the localization team and see what they currently support that may fit our use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
if (Verbose) | ||
{ | ||
//do a scan for support files which do not share the base name. | ||
foreach (var nonMDFile in allNonMDFiles) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you did find support files without a base file? What that caused by someone deleting the basename but not the supportfiles? I can't remember seeing this before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a single support file that is referenced from one of the renamed files, but its argument names are different, so it does not get renamed.
See my sample output for the example.
I didn't end up changing it as the name seemed short enough.
internal static void HandleRename(RenameOptions opts) | ||
{ | ||
|
||
Verbose=opts.Verbose; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding Verbose support.
{ | ||
foreach (var mdfile in allMdFiles) | ||
{ | ||
//md file contains a reference to the support file, but the names are not the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice consistency check. I don't remember seeing that case neither. But it was much fewer files when i did this.
thanks for the review- I will merge after the tests pass.
|
Purpose
https://jira.autodesk.com/browse/DYN-5508
TODO:
some doc files have names that are too long - this PR does the following:
an example of the kind of warning that will be generated:
See
rename_log.txt
for the log.Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Rename some documentation files so they can be shipped with dynamo.
Reviewers