Fix memory leak #13892
Merged
Fix memory leak #13892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -227,7 +227,6 @@ public DynamoLogger(DebugSettings debugSettings, string logDirectory, Boolean is | |||
| /// <param name="isServiceMode">We want restrict logging in service mode to console only due to lambda limitations.</param> | |||
| /// TODO(DYN-5757): Review usage of isTestMode,isTestMode,isServiceMode across Dynamo and see how we can consildate all these flags. | |||
| public DynamoLogger(DebugSettings debugSettings, string logDirectory, Boolean isTestMode, Boolean isCLIMode, Boolean isServiceMode) | |||
| : this(debugSettings, logDirectory, isTestMode) | |||
There was a problem hiding this comment.
ahh, did this sub LogToConsole twice?
|
Parallel tests passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8812/ |
|
Serial tests passed here: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1141/ |
|
@mjkkirschner PTAL |
|
@sm6srw is that event unsubscribed anywhere? (originally I mean, even before the PR that introduced the issue) |
|
Yes, it is. That was the leak. We subscribed twice but was only unsubscribing once. |
|
@mjkkirschner This new constructor was introduced here: #13860 |
mjkkirschner
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The logger constructors where called twice:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
FYIs