Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5652: Update internals visibility for Dynamo Player rewrite #13889

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

twastvedt
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

DYN-5652 - This PR updates the list of assembly names which have access to Dynamo Core internal types to include the new assembly names from the rewrite of Dynamo Player to use the new API.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update internals visibility for Dynamo Player rewrite.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

@saintentropy @BogdanZavu

@QilongTang QilongTang added this to the 2.18.0 milestone Apr 10, 2023
@QilongTang
Copy link
Contributor

hi @twastvedt Just to confirm, this is for upcoming 2.18 release right?

@twastvedt
Copy link
Contributor Author

Hi @QilongTang. It would be helpful if it was in 2.18 so we can start testing Player with the new project names without needing a dev build of Dynamo. We won't be releasing with these new names until 2.19 though.

@QilongTang QilongTang merged commit b13de1b into master Apr 11, 2023
@QilongTang QilongTang deleted the DYN-5652-internals branch April 11, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants