Multiple fixes for 2.18 #13880
Merged
Multiple fixes for 2.18 #13880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Apr 7, 2023
| @@ -1835,7 +1835,7 @@ Do you want to install the latest Dynamo update?</value> | |||
| <value>Run started with new working range...</value> | |||
| </data> | |||
| <data name="GroupDefaultText" xml:space="preserve"> | |||
| <value><Double click here to edit group description></value> | |||
There was a problem hiding this comment.
Are we using the same resource string in both Core and CoreWpf? Should we get rid of one of them?
There was a problem hiding this comment.
yes, we are using the same resource string in both, but the Wpf resources are unavailable in Core.
QilongTang
reviewed
Apr 7, 2023
| @@ -217,7 +217,7 @@ | |||
| Command="{Binding SignOutCommand}" | |||
| Name="logoutOption"> | |||
| <MenuItem.ToolTip> | |||
| <ToolTip Content="Sign Out" Style="{StaticResource GenericToolTipLight}"/> | |||
| <ToolTip Content="{x:Static p:Resources.LogoutMenuItemText}" Style="{StaticResource GenericToolTipLight}"/> | |||
QilongTang
reviewed
Apr 10, 2023
| //private void OnMoreInfoClicked(object sender, MouseButtonEventArgs e) | ||
| //{ | ||
| // dynViewModel.OpenDocumentationLinkCommand.Execute(new OpenDocumentationLinkEventArgs(new Uri(Dynamo.Wpf.Properties.Resources.NodeAutocompleteDocumentationUriString, UriKind.Relative))); | ||
| //} |
There was a problem hiding this comment.
@zeusongit Do we need to remove this commented code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-4930 - Update Group Defaults
DYN-5718 - Localize tooltip
DYN-5746 - Remove round edges
DYN-5751 - Format recommendation score
Display
100%properly, Min and Max width adjusted:Display
<1%for scores that are 0 or less than 1:Unified score display in score tooltip, by using the same converter to format score in code-behind as well:
DYN-5655 - Fix documentation link
Removed an extra function with the same name and added label container:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo