Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALSO-5603 Hide missing ML complete controls if hiding option is set #13859

Merged
merged 1 commit into from
Mar 31, 2023
Merged

ALSO-5603 Hide missing ML complete controls if hiding option is set #13859

merged 1 commit into from
Mar 31, 2023

Conversation

spodo99
Copy link
Contributor

@spodo99 spodo99 commented Mar 30, 2023

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Original PR adding HideAutocompleteMethodOptions was there #13834
This PR hides controls corresponding to ML Autocomplete feature which were missing in the first PR.
Conversation at https://autodesk.slack.com/archives/C1866AFQB/p1679067914031959

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@spodo99 spodo99 mentioned this pull request Mar 30, 2023
Merged
8 tasks
@sm6srw
Copy link
Contributor

sm6srw commented Mar 31, 2023

@QilongTang This looks good to me. Can you also take a quick look?

sm6srw
sm6srw approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sm6srw sm6srw merged commit 67bcba6 into DynamoDS:master Mar 31, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 31, 2023
@spodo99 @sm6srw
ALSO-5603 Hide missing ML complete controls if hiding option is set (D…
f3f1164 
…ynamoDS#13859)
@sm6srw sm6srw mentioned this pull request Mar 31, 2023
Merged
8 tasks
QilongTang pushed a commit that referenced this pull request Mar 31, 2023
@sm6srw @spodo99
Cp 13834 13859 (#13862)
ac1ae39 
* ALSO-5603 Add parameter hiding autocomplete options from the UI (#13834)

* ALSO-5603 Add parameter hiding autocomplete options from the UI

* ALSO-5603 Use IPreferences for hide autocomplete option

This needs to avoid breaking compatibility

* ALSO-5603 Add hide autocomplete option to the settings

* ALSO-5603 Fix unit test

* ALSO-5603 Hide missing ML complete controls if hiding option is set (#13859)

---------

Co-authored-by: spodo99 <[email protected]>
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
@spodo99 @sm6srw
ALSO-5603 Hide missing ML complete controls if hiding option is set (#…
95872aa 
…13859)
@spodo99 spodo99 deleted the spodo/ALSO-5603_fix branch April 25, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm6srw sm6srw sm6srw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spodo99 @sm6srw