feat(Library):adding-tooltip-for-node-category #13857
Conversation
There was a problem hiding this comment.
hmm what are these changes about new icons?
There was a problem hiding this comment.
Let me check that...
| } | ||
| // document.oncontextmenu = function () { | ||
| // return false; | ||
| //} |
There was a problem hiding this comment.
Do we still need these lines?
There was a problem hiding this comment.
My bad, I forgot to roll this back!
| @@ -48,6 +48,7 @@ | |||
| <Name>DynamoServices</Name> | |||
| <Private>False</Private> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\PythonMigrationViewExtension\PythonMigrationViewExtension.csproj" /> | |||
There was a problem hiding this comment.
What is the purpose of this new dependency?
There was a problem hiding this comment.
Not sure why this change was added. I didn't change this at least manually. I'm gonna remove that
Enzo707
force-pushed
the
DYN-4554-Node-Category-Tooltip
branch
from
ec2a6c3 to
1f7c3d6
Compare
| @@ -24,6 +25,7 @@ | |||
| using Microsoft.Web.WebView2.Core; | |||
| using Microsoft.Web.WebView2.Wpf; | |||
| using Newtonsoft.Json; | |||
| using ProtoCore.Lang; | |||
There was a problem hiding this comment.
Are these new using valid?
| @@ -64,4 +65,4 @@ | |||
| // You can specify all the values or you can default the Build and Revision Numbers | |||
| // by using the '*' as shown below: | |||
| // [assembly: AssemblyVersion("1.0.*")] | |||
| [assembly: AssemblyFileVersion("2.18.0.2986")] | |||
| [assembly: AssemblyFileVersion("2.18.0.4447")] | |||
There was a problem hiding this comment.
We usually skip the changes to this file, would you revert the changes to this file?
There was a problem hiding this comment.
I assume this is the updated minified version based on changes in the other repo
There was a problem hiding this comment.
What is the use of this additional here, I do not see this got referenced anywhere
Enzo707
force-pushed
the
DYN-4554-Node-Category-Tooltip
branch
from
1f7c3d6 to
6393806
Compare
|
Only sporadic test failure reported from run https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/8776/testReport/. Will merge once basic checks passed, these are triggered because I removed one empty line |
| @@ -19,7 +19,7 @@ namespace CoreNodeModels.Properties { | |||
| // class via a tool like ResGen or Visual Studio. | |||
| // To add or remove a member, edit your .ResX file then rerun ResGen | |||
| // with the /str option, or rebuild your VS project. | |||
| [global::System.CodeDom.Compiler.GeneratedCodeAttribute("System.Resources.Tools.StronglyTypedResourceBuilder", "16.0.0.0")] | |||
There was a problem hiding this comment.
@QilongTang just for curiosity, this change doesn't affect the way the resources are compiled?
I was asking because when I add resources in VS2022 this line is usually updated and the compilation starts to fail
Thanks
There was a problem hiding this comment.
hi @RobertGlobant20 I think v16 belongs to VS2019 and v17 belongs to VS2022. In the past, when we have multiple devs using different versions of VS, there is always this version change back and forth. But I would not expect this impacting compilation result. Do you start to see failure on master now? It builds fine for me on VS2022
There was a problem hiding this comment.
There are no failures, then if it builds I think we are fine.
* feat(Library):adding-tooltip-for-node-category * Update AssemblySharedInfo.cs --------- Co-authored-by: Aaron (Qilong) <[email protected]>
Purpose
There are three categories of nodes inside Dynamo; Creators, Actions and Queries, which are currently demarcated by a green cross, orange lighting bolt and blue question mark. This PR add tooltips to make it easier to explaining what each of these buckets of nodes does.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Now a tooltip will shown over each node category displaying a brief explanation about what does the node bucket do.
Reviewers
@QilongTang