Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch node custom size serialization #13844

Merged
merged 7 commits into from
Mar 28, 2023
Merged

Watch node custom size serialization #13844

merged 7 commits into from
Mar 28, 2023

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Mar 22, 2023 •
edited
Loading

Purpose

Size serialization and deserialization for watch nodes.

Task: https://jira.autodesk.com/browse/DYN-3365

watch node size serialization

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang @Amoursol @DynamoDS/dynamo

@reddyashish
Copy link
Contributor Author

@Amoursol I have tested multiple cases but would like you to test this out and let me know if i am missing anything

@reddyashish reddyashish marked this pull request as ready for review March 23, 2023 19:40
@reddyashish reddyashish changed the title [WIP] Watch node custom size serialization Watch node custom size serialization Mar 23, 2023
@reddyashish
Copy link
Contributor Author

Added a test.

QilongTang
QilongTang reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments

@QilongTang QilongTang added this to the 2.18.0 milestone Mar 27, 2023
@reddyashish reddyashish merged commit 6447f9e into DynamoDS:master Mar 28, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
@reddyashish @sm6srw
Watch node custom size serialization (DynamoDS#13844)
92bde77 
* Watch node custom size serialization

* Fix tests

* Fix edge cases.

* Add test

* Fix tests

* comments
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
@reddyashish @sm6srw
Watch node custom size serialization (#13844)
d4ce715 
* Watch node custom size serialization

* Fix tests

* Fix edge cases.

* Add test

* Fix tests

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikhinja Mikhinja Mikhinja left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@reddyashish @QilongTang @Mikhinja