Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-5676-ColorPicker-CustomColors-DefaultColor #13836

Merged
merged 1 commit into from
Mar 18, 2023
Merged

DYN-5676-ColorPicker-CustomColors-DefaultColor #13836

merged 1 commit into from
Mar 18, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

When there is no color selected and the custom colors Popup is opened and none color was selected the sliders are disabled. Now with this fix the default color when the custom colors Popup is opened will be black and sliders will be enabled by default.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Default color when the custom colors Popup is opened will be black.

Reviewers

@QilongTang

FYIs

@avidit

When there is no color selected and the custom colors Popup is opened and none color was selected  the sliders are disabled.
Now with this fix the default color when  the custom colors Popup is opened will be black..
@QilongTang QilongTang added this to the 2.18.0 milestone Mar 17, 2023
@QilongTang QilongTang merged commit dd87c01 into DynamoDS:master Mar 18, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
When there is no color selected and the custom colors Popup is opened and none color was selected  the sliders are disabled.
Now with this fix the default color when  the custom colors Popup is opened will be black..
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
When there is no color selected and the custom colors Popup is opened and none color was selected  the sliders are disabled.
Now with this fix the default color when  the custom colors Popup is opened will be black..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants