Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tours buttons behavior #13808

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Tours buttons behavior #13808

merged 2 commits into from
Mar 10, 2023

Conversation

jesusalvino
Copy link
Contributor

Purpose

Considering the buttons behavior of the 3 Tours from the improvement https://jira.autodesk.com/browse/DYN-5404

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20

@jesusalvino
Copy link
Contributor Author

Tours_Enabling

@jesusalvino
Copy link
Contributor Author

The test WorkspaceContextMenu_IfSubmenuOpenOnMouseHover passes locally

imagen

@QilongTang QilongTang added this to the 2.18.0 milestone Mar 10, 2023
@QilongTang QilongTang merged commit 12155b0 into DynamoDS:master Mar 10, 2023
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
@jesusalvino @sm6srw
Tours buttons behavior (DynamoDS#13808)
118f210 
* Tours buttons behavior

* Disabling Toolbar Buttons on the GuidesManager
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
@jesusalvino @sm6srw
Tours buttons behavior (#13808)
07db5f4 
* Tours buttons behavior

* Disabling Toolbar Buttons on the GuidesManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jesusalvino @QilongTang