Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Locale Selection in Dynamo Preferences Panel #13802

Merged
merged 14 commits into from
Mar 9, 2023
Merged

Enable Locale Selection in Dynamo Preferences Panel #13802

merged 14 commits into from
Mar 9, 2023

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Mar 7, 2023 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR enables Locale selection in Dynamo Preferences Panel. As a result, Dynamo will be localized in the new locale after a restart. Notice that the selection does not affect current Dynamo session.

User experience: (notice the new language selections resources are in DynamoCore not localized yet)
New info icon added
image

Toast notification added
image

Gif:
ChangeLocale

Serialization changes:
image

TODO:

  • Try toast notification and add information icon

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Enable Locale Selection in Dynamo Preferences Panel

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 2.18.0 milestone Mar 7, 2023
@QilongTang QilongTang marked this pull request as ready for review March 7, 2023 17:57
reddyashish
reddyashish approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RobertGlobant20
RobertGlobant20 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

src/DynamoCore/Configuration/PreferenceSettings.cs Show resolved Hide resolved
@QilongTang QilongTang merged commit 0779a86 into master Mar 9, 2023
@QilongTang QilongTang deleted the EnableLocaleSelection branch March 9, 2023 14:01
sm6srw pushed a commit to sm6srw/Dynamo that referenced this pull request Mar 29, 2023
@QilongTang @sm6srw
Enable Locale Selection in Dynamo Preferences Panel (DynamoDS#13802)
ab2bfed 
* First Commit

* Update locale on startup

* spelling

* dynamically display and select current locale

* Clean up

* Unit Tests

* Add toast notification

* Move constants out of PreferencesSetting object

* Add info icon and tooltip

* Update PreferenceSettingsTests.cs

* Update test file

* Remove interface change
sm6srw pushed a commit that referenced this pull request Apr 5, 2023
@QilongTang @sm6srw
Enable Locale Selection in Dynamo Preferences Panel (#13802)
7f2a31e 
* First Commit

* Update locale on startup

* spelling

* dynamically display and select current locale

* Clean up

* Unit Tests

* Add toast notification

* Move constants out of PreferencesSetting object

* Add info icon and tooltip

* Update PreferenceSettingsTests.cs

* Update test file

* Remove interface change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

@RobertGlobant20 RobertGlobant20 RobertGlobant20 approved these changes

@reddyashish reddyashish reddyashish approved these changes

@Jingyi-Wen Jingyi-Wen Awaiting requested review from Jingyi-Wen

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QilongTang @mjkkirschner @reddyashish @RobertGlobant20